Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/doom destroys blocks on explosion. #1644

Closed
rackd opened this issue May 9, 2016 · 8 comments
Closed

/doom destroys blocks on explosion. #1644

rackd opened this issue May 9, 2016 · 8 comments
Labels
Issue: Bug Confirmed Issue: Bug

Comments

@rackd
Copy link
Contributor

rackd commented May 9, 2016

I'm not quite sure if this is a feature or a bug. When using /doom it destroys blocks. The issue with this is it can cause unwanted grief.
@rackd
Copy link
Contributor Author

rackd commented May 9, 2016 •
edited
Loading

I had some free time so I made a video explaining the bug. I have developed a very simple fix. If this issue is accepted, I will be glad to share.

YouTube video 1:08 seconds

@WilliePlaysMC
Copy link

This isn't a bug. It was intended. However it is still an Enhancement and I believe it shouldn't just explode. As I have ruined many builds on my server while messing around with TFM.

@rovertdude
Copy link

I think it should disable the explosion doing damage - it can cause griefing accidentally and irreparably quite a bit.

@JeromSar
Copy link
Member

@WilliePlaysMC How exactly was this intended behavior?

@WilliePlaysMC
Copy link

WilliePlaysMC commented May 11, 2016 •
edited
Loading

@JeromSar I am pretty sure this had been the case since TFM 4.3 or even earlier.

"// generate explosion
player.getWorld().createExplosion(player.getLocation(), 4F);"
In the code for TFM 4.3 it was pretty much intended to create an explosion as indicated by the "generate explosion"

EDIT:Just check that "// generate explosion" is also in TFM 5.0's code. Since you(or another dev) made a note for it to generate an explosion. I believe this was intended behavior.

@mayokek
Copy link

mayokek commented May 11, 2016 •
edited
Loading

Actually, explosion won't occur if the explosion toggle is turned false, @WilliePlaysMC.
v4.3's explosion behaviour works well, perhaps it's 1.9.2 or a bug in TFM 5.0

@Wild1145
Copy link
Member

I think it was intended to create an explosion effect but not break any blocks...

@rovertdude
Copy link

@AvalancheYT My server had explosions toggled false however /doom still broke spawn when we /doom'd someone.

JeromSar pushed a commit that referenced this issue May 14, 2016
@JeromSar
Resolves #1644 (#1716)
1a16f06 
Fix /doom breaking blocks
JeromSar pushed a commit that referenced this issue Aug 26, 2016
@JeromSar
Resolves #1644 (#1716)
b3e0539 
Fix /doom breaking blocks
JeromSar pushed a commit that referenced this issue Aug 26, 2016
@JeromSar
# This is a combination of 27 commits.
524dd1d 
# The first commit's message is:
Readd /uall and /dtoggle. Resolves #1793

# The 2nd commit message will be skipped:

#	Update Command_disguisetoggle.java

# The 3rd commit message will be skipped:

#	Update LibsDisguisesBridge.java

# The 4th commit message will be skipped:

#	Update Command_disguisetoggle.java

# The 5th commit message will be skipped:

#	Update LibsDisguisesBridge.java

# The 6th commit message will be skipped:

#	Update Command_undisguiseall.java

# The 7th commit message will be skipped:

#	Check for errors, and add soft depend

# The 8th commit message will be skipped:

#	Add uall

# The 9th commit message will be skipped:

#	Fix Dtoggle

# The 10th commit message will be skipped:

#	Fix Dtoggle part 2

# The 11th commit message will be skipped:

#	Formatting

# The 12th commit message will be skipped:

#	More formatting

# The 13th commit message will be skipped:

#	Remove unused import

# The 14th commit message will be skipped:

#	Fix possible NPE

# The 15th commit message will be skipped:

#	Fixes

# The 16th commit message will be skipped:

#	fixes

# The 17th commit message will be skipped:

#	fixes

# The 18th commit message will be skipped:

#	Update LibsDisguisesBridge.java

# The 19th commit message will be skipped:

#	Update Command_disguisetoggle.java

# The 20th commit message will be skipped:

#	Update Command_undisguiseall.java

# The 21st commit message will be skipped:

#	Add space

# The 22nd commit message will be skipped:

#	Add space

# The 23rd commit message will be skipped:

#	Resolves #1644 (#1716)
#
#	Fix /doom breaking blocks

# The 24th commit message will be skipped:

#	Block structure blocks from being placed

# The 25th commit message will be skipped:

#	Improved wildcard command blocking. Fixes #1842

# The 26th commit message will be skipped:

#	Update the target IP when using /myadmin -o. Fixes #1841

# The 27th commit message will be skipped:

#	Block sign interaction. Fixes #1831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Bug Confirmed Issue: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@JeromSar @rackd @Wild1145 @mayokek @rovertdude @WilliePlaysMC