Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using /myadmin clearips on another admin gives them the sender's IP #1841

Closed
Obi2 opened this issue Aug 24, 2016 · 3 comments
Closed

Using /myadmin clearips on another admin gives them the sender's IP #1841

Obi2 opened this issue Aug 24, 2016 · 3 comments
Labels
Issue: Bug Confirmed Issue: Bug
Milestone
F (5.1)

Comments

@Obi2
Copy link

Obi2 commented Aug 24, 2016 •
edited
Loading

An admin had two supered IPs - using /myadmin -o clearips on the admin for some reason gave them my (the sender's) IP.

I don't think targetIp (line 34) is updated if the target is changed to another player.
@mayokek
Copy link

mayokek commented Aug 25, 2016

If you read bit further, it actually does change. Line 41

@JeromSar JeromSar added this to the F (5.1) milestone Aug 25, 2016
@JeromSar
Copy link
Member

JeromSar commented Aug 25, 2016 •
edited
Loading

You're right. It's on the TODO list. :)
@AvalancheYT I think you misunderstood. targetIp doesn't change.

@mayokek
Copy link

mayokek commented Aug 26, 2016

Oh, I was mistaken.

JeromSar added a commit that referenced this issue Aug 26, 2016
@JeromSar
Update the target IP when using /myadmin -o. Fixes #1841
71c46b5
JeromSar added a commit that referenced this issue Aug 26, 2016
@JeromSar
Update the target IP when using /myadmin -o. Fixes #1841
ea6af51
JeromSar pushed a commit that referenced this issue Aug 26, 2016
@JeromSar
# This is a combination of 27 commits.
524dd1d 
# The first commit's message is:
Readd /uall and /dtoggle. Resolves #1793

# The 2nd commit message will be skipped:

#	Update Command_disguisetoggle.java

# The 3rd commit message will be skipped:

#	Update LibsDisguisesBridge.java

# The 4th commit message will be skipped:

#	Update Command_disguisetoggle.java

# The 5th commit message will be skipped:

#	Update LibsDisguisesBridge.java

# The 6th commit message will be skipped:

#	Update Command_undisguiseall.java

# The 7th commit message will be skipped:

#	Check for errors, and add soft depend

# The 8th commit message will be skipped:

#	Add uall

# The 9th commit message will be skipped:

#	Fix Dtoggle

# The 10th commit message will be skipped:

#	Fix Dtoggle part 2

# The 11th commit message will be skipped:

#	Formatting

# The 12th commit message will be skipped:

#	More formatting

# The 13th commit message will be skipped:

#	Remove unused import

# The 14th commit message will be skipped:

#	Fix possible NPE

# The 15th commit message will be skipped:

#	Fixes

# The 16th commit message will be skipped:

#	fixes

# The 17th commit message will be skipped:

#	fixes

# The 18th commit message will be skipped:

#	Update LibsDisguisesBridge.java

# The 19th commit message will be skipped:

#	Update Command_disguisetoggle.java

# The 20th commit message will be skipped:

#	Update Command_undisguiseall.java

# The 21st commit message will be skipped:

#	Add space

# The 22nd commit message will be skipped:

#	Add space

# The 23rd commit message will be skipped:

#	Resolves #1644 (#1716)
#
#	Fix /doom breaking blocks

# The 24th commit message will be skipped:

#	Block structure blocks from being placed

# The 25th commit message will be skipped:

#	Improved wildcard command blocking. Fixes #1842

# The 26th commit message will be skipped:

#	Update the target IP when using /myadmin -o. Fixes #1841

# The 27th commit message will be skipped:

#	Block sign interaction. Fixes #1831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Bug Confirmed Issue: Bug
Projects
None yet
Milestone
F (5.1)
Development

No branches or pull requests
4 participants
@JeromSar @Obi2 @lemonsked @mayokek