Remove /invis smite, add /invis clear #1011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves TotalFreedom#959
|
Again, as stated on the issue I disagree with removing TFM functionality for the sake of it. |
| @@ -11,19 +11,19 @@ | |||
| import org.bukkit.potion.PotionEffectType; | |||
|
|
|||
| @CommandPermissions(level = AdminLevel.SUPER, source = SourceType.BOTH) | |||
| @CommandParameters(description = "Shows (optionally smites) invisisible players", usage = "/<command> (smite)") | |||
| @CommandParameters(description = "Shows (optionally clears) invisisible players", usage = "/<command> (clear)") | |||
There was a problem hiding this comment.
This should be an optional parameter. Usage is [parameter]
|
@LegendIsAwesomes One small change and this PR is good to go. |
|
There we go @JeromSar |
|
@LegendIsAwesomes Thanks for contributing! This PR is ready to merge and will be soon. :) |
|
It's been accepted, invis smite just smites innocents |
|
@DUFCLiam The implementation is fine as-is. For reasoning behind removing /invis smite, see the original issue. |
| { | ||
| playerMsg("Smitten " + smites + " players"); | ||
| playerMsg("Cleared invisibility effect from " + clears + " players""); |
|
Fixed. @JeromSar |
JeromSar
pushed a commit
that referenced
this pull request
Nov 13, 2016
|
Merged in 0eb0c7a. Thanks for contributing! |
JeromSar
pushed a commit
that referenced
this pull request
Jan 8, 2017
lemonsked
pushed a commit
to lemonsked/TotalFreedomMod
that referenced
this pull request
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #959