Replace invis smite to clear #975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested and worked. There is some changes I will make.
|
Looks good to me. |
Now the counter is working.
|
Don't think we should be replacing the smite functionality as stated in the two associated issues. |
|
@Wild1145, Prozza liked my idea to replace it. Smiting them for invis is just giving them a wrong idea. |
|
@OnlineRepz Just because he liked the idea does not mean the idea is final / will be approved. I like the idea of knowing the national lottery numbers, but I have to guess them like everyone else. |
JeromSar
changed the title
|
Another PR which resolves the issue has been accepted, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and worked.
Resolves issue #959