-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setting of CreateNoWindow
to reduce overhead
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyrrrz
changed the title
Removing setting of CreateNoWindow to reduce overhead
Remove setting of Mar 14, 2022
CreateNoWindow
to reduce overhead
This proposed fix will check if the current application has a console or not. If it does not, it will set ProcessStartInfo.CreateNoWindow = true. If it does have a console, CreateNoWindow will not be set, avoiding the added overhead of setting it. |
Tyrrrz
requested changes
Mar 14, 2022
Tyrrrz
reviewed
Mar 14, 2022
Tyrrrz
reviewed
Mar 14, 2022
Tyrrrz
reviewed
Mar 14, 2022
@retik okay, just to make sure, you tested all previously scenarios with this and it works correctly, right? |
Tyrrrz
approved these changes
Mar 14, 2022
Tyrrrz
reviewed
Mar 14, 2022
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed a 30-40ms overhead added to the execution time of any process when you set ProcessStartInfo.CreateNoWindow to anything, true or false. I'm not sure why exactly this is, but you can see the difference in the benchmarks really easily. CliWrap sets CreateNoWindow = true and UseShellExecute = false. But as far as I can tell, UseShellExecute = false is the default and CreateNoWindow doesn't work unless UseShellExecute = true. So removing those two settings from the ProcessStartInfo is functionally equivalent to the way they are currently, but it allows processes to run without the 30ms overhead.