Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting of CreateNoWindow to reduce overhead #142

Merged
merged 8 commits into from
Mar 14, 2022
Merged

Remove setting of CreateNoWindow to reduce overhead #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33900a2
Removing setting of CreateNoWindow to reduce overhead
ian-g-holm-intel Mar 14, 2022
eb16435
Improving solution to work for gui/console applications alike
ian-g-holm-intel Mar 14, 2022
452b035
Moving native method to its own file and adding windows check
ian-g-holm-intel Mar 14, 2022
78d7392
Updating comments.
ian-g-holm-intel Mar 14, 2022
d547ea8
Update CliWrap/Command.cs
Tyrrrz Mar 14, 2022
9ab1293
Update CliWrap/Utils/NativeMethods.cs
Tyrrrz Mar 14, 2022
04d5d36
Update CliWrap/Utils/NativeMethods.cs
Tyrrrz Mar 14, 2022
7e044b4
Update CliWrap/Utils/NativeMethods.cs
Tyrrrz Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions CliWrap/Command.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,17 @@ private ProcessStartInfo GetStartInfo()
RedirectStandardInput = true,
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
CreateNoWindow = true
UseShellExecute = false
};

// Setting CreateNoWindow has a 30ms overhead added to execution time of the process.
// A window won't be created for console applications even when CreateNoWindow = false,
// so it's only necessary to set it if there is no console.
// This check is only necessary on Windows platforms because CreateNoWindow does not work on MacOS or Linux.
// https://github.com/Tyrrrz/CliWrap/pull/142
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && NativeMethods.GetConsoleWindow() == IntPtr.Zero)
startInfo.CreateNoWindow = true;

// Domain and password are only supported on Windows
if (Credentials.Domain is not null || Credentials.Password is not null)
{
Expand Down
10 changes: 10 additions & 0 deletions CliWrap/Utils/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
using System;
using System.Runtime.InteropServices;

namespace CliWrap.Utils;

internal static class NativeMethods
{
[DllImport("kernel32.dll")]
public static extern IntPtr GetConsoleWindow();
}