Per-stage shader keywords in HDRP #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # com.unity.render-pipelines.high-definition/Editor/Material/Decal/ShaderGraph/HDDecalSubTarget.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/HDTarget.cs # com.unity.render-pipelines.high-definition/Editor/ShaderGraph/Nodes/RayTracingNode.cs # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/DeferredTile.shader # com.unity.render-pipelines.high-definition/Runtime/Material/AxF/AxF.shader # com.unity.render-pipelines.high-definition/Runtime/Material/LayeredLit/LayeredLit.shader # com.unity.render-pipelines.high-definition/Runtime/Material/Lit/Lit.shader
# Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Material/AxF/AxF.shader # com.unity.render-pipelines.high-definition/Runtime/Material/Decal/Decal.shader # com.unity.shadergraph/Editor/Generation/Processors/Generator.cs
FrancescoC-unity
requested review from
alelievr,
sebastienlagarde and
anisunity
FrancescoC-unity
changed the title
RSlysz
pushed a commit
that referenced
this pull request
Jan 6, 2021
* Enable greetings.yaml * Save yml files * Add comments * Add .github folder to codeowners
RSlysz
pushed a commit
that referenced
this pull request
Jan 6, 2021
|
It appears that you made a non-draft PR! |
alelievr
reviewed
Jan 7, 2021
cdxntchou
approved these changes
Jan 14, 2021
sebastienlagarde
approved these changes
Jan 14, 2021
sebastienlagarde
approved these changes
Jan 14, 2021
|
Adding QA: QA please try to load a project like SpaceShip or Palace, and build a player a check that everything is fine. Thanks |
ghost
self-requested a review
iM0ve
approved these changes
Jan 15, 2021
sebastienlagarde
approved these changes
Jan 15, 2021
ghost
approved these changes
Jan 15, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Jan 19, 2021
sebastienlagarde
added a commit
that referenced
this pull request
Jan 19, 2021
* Per-stage shader keywords in HDRP -bis #2996 * Fix DX12 alembic test * miss SG * Update LayeredLit.shader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR HDRP will use per-stage keywords what that means is that we can do stuff like
multi_compile_fragmentto have only the fragment shader variant computed. It is very important to define one separate line per stage that needs to include the keyword. This work for both multi compiles and shader_featuresThis is has to be done manually for code shaders (I did a pass on our shaders, being conservative to be safe) and I added a field to have that easily generated in SG.
This reduces the number of compiled shader programs with all the benefits that come from that.
I ran test manually and they pass.