[1312646][1321306] Correctly initialize pixel perfect camera rect on awake + Fix wrong orthoSize being updated #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
kennytann
changed the title
erikabar
approved these changes
May 17, 2021
phi-lira
approved these changes
May 17, 2021
kennytann
changed the title
|
Fix verified on branch: Version: 2021.2.0a17.2411 case 1312646: Verified using user project, all 3 frames of debug logs are consistent at "0.8888889" |
BoonKiangTan
approved these changes
May 19, 2021
unity-cchu
approved these changes
May 20, 2021
CertifiedRice
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
1312646 - Pixel perfect camera's rect was not getting properly initialized. Systems or users depending on the camera's size are unable to retrieve the correct values.
1321306 - Fixed a bug where the pixel perfect camera was updated with the wrong ortho size due to it using the scene view's camera
Testing status
FB: https://fogbugz.unity3d.com/f/cases/1312646/
Ensure Pixel Perfect Camera Height is correct on Start() in scripting.
FB: https://fogbugz.unity3d.com/f/cases/1321306/
Ensure Game view is not longer zoomed in when selecting the main camera in the scene hierarchy.
Comments to reviewers
Notes for the reviewers you have assigned.