Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1312646][1321306] Correctly initialize pixel perfect camera rect on awake + Fix wrong orthoSize being updated #4513

Merged
merged 11 commits into from
May 31, 2021
Merged

[1312646][1321306] Correctly initialize pixel perfect camera rect on awake + Fix wrong orthoSize being updated #4513

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c3b0465
Correctly initialize pixel perfect camera rect on awake
kennytann May 12, 2021
0763fb1
Fix spacing
kennytann May 12, 2021
7e65280
add to changelog
kennytann May 12, 2021
2f4e24f
update changelog
kennytann May 12, 2021
17f331b
Fix a bug in pixel perfect camera where it was updating orthosize inc…
kennytann May 19, 2021
28cf13e
Only update camera with pixel perfect i.e. not scene or preview cameras
kennytann May 20, 2021
1c4a5da
Merge branch 'master' into 2d/init-pp-cam-rect
kennytann May 20, 2021
0e80034
Added graphics test for cinemachine and added cinemachine package to …
kennytann May 20, 2021
d6fa298
Merge branch 'master' into 2d/init-pp-cam-rect
kennytann May 25, 2021
a34e1e2
Disable post processing test. Re-enable together with post proccessin…
kennytann May 27, 2021
4f87a0a
Update reference images for graphics test
kennytann May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a bug in pixel perfect camera where it was updating orthosize inc… 
…orrectly
  • Loading branch information
@kennytann
kennytann committed May 19, 2021
commit 17f331b60d1948d5743eac57e1cc8ec9a909f5d4
3 changes: 3 additions & 0 deletions com.unity.render-pipelines.universal/Runtime/2D/PixelPerfectCamera.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,9 @@ void UpdateCameraProperties()

void OnBeginContextRendering(ScriptableRenderContext context, List<Camera> cameras)
{
if (!cameras.Exists(x => x == m_Camera))
return;

UpdateCameraProperties();
PixelSnap();

Expand Down