Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URP] Fullscreen ShaderGraph feature #6142

Closed
wants to merge 55 commits into from

Conversation

alelievr
Copy link
Member

Purpose of this PR

⚠️ This PR depends on #6110 (so it needs to be merged after)

Included in this PR:

  • Implementation of the fullscreen sub-target for Universal
    image

  • A new Render Feature for Fullscreen effects (compatible with all renderers)
    image

  • The URP Sample Buffer node, allows to access the normal and motion vector buffers in ShaderGraph.
    image

If you have any questions regarding this feature, you can ask in #devs-fullscreen-master-node.


Testing status

Fullscreen target test doc: https://confluence.unity3d.com/display/HDRP/Fullscreen+Target

Automated tests for URP fullscreen feature are still missing.

Note for QA:

This work is split into 3 PRs for ease of reviewing. If you want to test everything (URP, HDRP, and builtin implementation) I'd recommend to use the sg/fullscreen-target branch

@alelievr alelievr requested review from phi-lira, Verasl and a team October 26, 2021 10:59
@alelievr alelievr self-assigned this Oct 26, 2021
@alelievr alelievr marked this pull request as ready for review October 26, 2021 10:59
@alelievr alelievr requested review from a team as code owners October 26, 2021 10:59
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Shader Graph
/jobDefinition/.yamato%252Fall-shadergraph.yml%2523PR_ShaderGraph_trunk
Depending on your PR, you may also want
/jobDefinition/.yamato%252Fall-shadergraph_builtin_foundation.yml%2523PR_ShaderGraph_BuiltIn_Foundation_trunk
/jobDefinition/.yamato%252Fall-shadergraph_builtin_lighting.yml%2523PR_ShaderGraph_BuiltIn_Lighting_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@alelievr
Copy link
Member Author

alelievr commented Feb 1, 2022

Replaced by #6943

@alelievr alelievr deleted the urp/fullscreen-subtarget-pr branch February 25, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant