ShaderGraph Fullscreen Target #6943

alelievr · 2022-02-01T18:06:23Z

Purpose of this PR

Introduce the Fullscreen ShaderGraph target feature. This PR represents the work on all 3 render pipelines, thus replacing these 3 PRs: #6110, #6142, and #6141

Useful links:
JIRA: https://jira.unity3d.com/browse/HDRP-99
Test doc: https://confluence.unity3d.com/pages/viewpage.action?spaceKey=HDRP&title=Fullscreen+Target
Original design doc: https://docs.google.com/document/d/1SOK6SsQhH6DvBby_K3f9O0M3sligYDygxBdceNXVejQ/edit
Documentation (all pipelines): https://docs.google.com/document/d/1-BrUqaZaU6J1xIAeivfI2pipq5UU5ff30V1TfAIoZ8Y/edit#heading=h.mfblxnptiedt
ShaderGraph only documentation: https://docs.google.com/document/d/1hnuSH4uOZt5GLNNr_i1ZShQOPn9FoKwu6ZU437OijZo/edit#heading=h.g99rfupk8j0g
HDRP only documentation: https://docs.google.com/document/d/1-N9K6dlxnQNs9LXEa4VZJsceozvizYXuBMTnOv15RVU/edit#heading=h.xjzd87l8xj31
Custom Render Texture documentation: https://docs.google.com/document/d/1Fh_1VgqWWBR4fRDwdzxlcezD6USJU6dOsxVWGa_4Tcs/edit#heading=h.n33sfzb6wrwn

ABV: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/sg%252Ffullscreen-target/.yamato%252F_abv.yml%2523all_project_ci_trunk/11321133/job

…ines

…tation

…odes in HDRP

…ints

… is compatible with current RP

jessebarker · 2022-02-14T21:54:52Z

I'm concerned that there are changes in here for the built-in target, but I don' t see any tests to support updates to the built-in target (possible I missed something with all of the changes).

esmelusina · 2022-02-14T23:19:37Z

I'm concerned that there are changes in here for the built-in target, but I don' t see any tests to support updates to the built-in target (possible I missed something with all of the changes).

To add on to that, I was under the impression that built-in support was getting dropped?

alelievr · 2022-02-15T16:22:51Z

@esmelusina @jessebarker Thanks there were some remaining bits that I needed to revert for builtin. And yes we decided to remove the builtin implementation, for now, we'll see if we add it back later in a 2nd PR

# Conflicts: # TestProjects/HDRP_Tests/Assets/HDRPDefaultResources/HDRenderPipelineGlobalSettings.asset # com.unity.render-pipelines.high-definition/Documentation~/whats-new-13.md

TomasKiniulis

Testing status:

Verified the leftover logged issues
Validated with Antoine that CRT actually works correctly when texture is initialized
Tested fullscreen test project builds on Xbox and @JMargevics tested PS4. Xbox works correctly
PS4 freezes on some scenes. Need to investigate freezes a bit to be sure this is not caused by the fullscreen target.

esmelusina · 2022-02-16T00:37:17Z

@esmelusina @jessebarker Thanks there were some remaining bits that I needed to revert for builtin. And yes we decided to remove the builtin implementation, for now, we'll see if we add it back later in a 2nd PR

I'm under the impression that it will not need to be added back in at all, though please verify with us beforehand to save any extra trouble there.

com.unity.shadergraph/Editor/Generation/Targets/CustomRenderTexture/CustomTextureNodes.cs

TomasKiniulis · 2022-02-17T17:02:51Z

Testing status:
Verified the leftover logged issues
Validated with Antoine that CRT actually works correctly when texture is initialized
Tested fullscreen test project builds on Xbox and @JMargevics tested PS4. Xbox works correctly
PS4 freezes on some scenes. Need to investigate freezes a bit to be sure this is not caused by the fullscreen target.

Jans rechecked PS4. Freezes are unrelated - caused missing script component. However I'm running into a new issue where displaying result of Custom Color Buffer stretches the view when Planar Probe is in view.

2022-02-17.17-15-15.mp4

esmelusina

Looks good; any details on the manual testing coverage going on forward?

...ity.render-pipelines.high-definition/Editor/Material/ShaderGraph/Nodes/HDSampleBufferNode.cs

sebastienlagarde · 2022-02-17T18:21:26Z

...nity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.RenderGraph.cs

@@ -49,6 +49,9 @@ public partial class HDRenderPipeline
                // Be careful, ComputePackedMipChainInfo needs the render texture size and not the viewport size. Otherwise it would compute the wrong size.
                hdCamera.depthBufferMipChainInfo.ComputePackedMipChainInfo(RTHandles.rtHandleProperties.currentRenderTargetSize);

+                // Bind the depth pyramid offset info for the HDSceneDepth node in ShaderGraph. This can be used by users in custom passes.
+                commandBuffer.SetGlobalBuffer(HDShaderIDs._DepthPyramidMipLevelOffsets, hdCamera.depthBufferMipChainInfo.GetOffsetBufferData(m_DepthPyramidMipLevelOffsetsBuffer));


@JulienIgnace-Unity for awareness

com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderVariables.hlsl

alelievr · 2022-02-17T18:29:33Z

@esmelusina Did you look at the test document @TomasKiniulis made? https://unity.okta.com/app/unitytechnologies_confluence_1/exk6c576bcfmEyqsS2p7/sso/saml

alelievr added 30 commits September 16, 2021 15:39

Initial fullscreen target files

397ab27

Added blend modes + depth output option

b5e9ddf

Added read mask in stencil descriptor

d197e65

Added Blit support

2a70be5

Fixed ShaderGraph default shader generator outputing 2 CustomEditor l…

97047c2

…ines

Added Fullscreen SG material GUI

50f8621

Add ability to disable stencil and blend in shadergraph (for material)

e7ffca3

refactor to have one sub-target per pipeline + working position compu…

28f538c

…tation

Add URP fullscreen pass implementation

5258060

Added IsNodeAllowedBySubTarget API

a0ab151

Added node filtering for the fulscreen sub-target + fix scene color n…

851792f

…odes in HDRP

Add create callback + separate colorRGBA into color RGB + A

82cdcfc

Move shadergraph fullscreen create menu

18c821a

Fix camera color buffer sampling in all HDRP custom pass injection po…

baf754a

…ints

Added HD scene depth node

da7674d

Fix default custom editor in ShaderGraph being only applied if target…

dbc1e1c

… is compatible with current RP

Fix alpha block by default

648fc95

Implemented builtin fullscreen pass (compatible with PPV2)

9b60865

HD Sample depth node now sample the depth instead of loading it

0b0b799

Fixed color LOD sampling

57ca8e0

Use BaseColor instead of Color block

f503acd

Add the HD Sample buffer node

4dc9cb7

started to add the draw fullscreen render feature in URP

0b0998f

Fix todo

e5abaf6

Fix custom post process file creating in HDRP

5a8d654

Fix render feature debug name + subgraphs in Fullscreen SGs

07d459b

Added options to bind normal and motion vectors in URP

7eb0b01

Normal sampling in Universal sample buffer node

a33cdb7

Merge remote-tracking branch 'origin/master' into sg/fullscreen-target

cc4314a

Fix depth test compilation

17997a0

alelievr added 3 commits February 15, 2022 17:05

revert builtin files

3d59817

Update compositor to use fullscreen shader by default

4b57489

revert remaining files

350d534

Merge branch 'master' into sg/fullscreen-target

8e71f65

# Conflicts: # TestProjects/HDRP_Tests/Assets/HDRPDefaultResources/HDRenderPipelineGlobalSettings.asset # com.unity.render-pipelines.high-definition/Documentation~/whats-new-13.md

TomasKiniulis reviewed Feb 15, 2022

View reviewed changes

Apply formatting changes

c501000

esmelusina reviewed Feb 16, 2022

View reviewed changes

com.unity.shadergraph/Editor/Generation/Targets/CustomRenderTexture/CustomTextureNodes.cs Outdated Show resolved Hide resolved

Split custom render texture SG nodes to different files

7dde879

esmelusina self-requested a review February 17, 2022 17:27

esmelusina approved these changes Feb 17, 2022

View reviewed changes

alelievr added 2 commits February 17, 2022 18:48

Merge branch 'master' into sg/fullscreen-target

9ab2db3

Fix what's new

48d17f7

sebastienlagarde reviewed Feb 17, 2022

View reviewed changes

...ity.render-pipelines.high-definition/Editor/Material/ShaderGraph/Nodes/HDSampleBufferNode.cs Outdated Show resolved Hide resolved

sebastienlagarde reviewed Feb 17, 2022

View reviewed changes

...ity.render-pipelines.high-definition/Editor/Material/ShaderGraph/Nodes/HDSampleBufferNode.cs Outdated Show resolved Hide resolved

sebastienlagarde reviewed Feb 17, 2022

View reviewed changes

...ity.render-pipelines.high-definition/Editor/Material/ShaderGraph/Nodes/HDSampleBufferNode.cs Outdated Show resolved Hide resolved

Fix compilation + smoothness and sample to LOD

56ac394

sebastienlagarde reviewed Feb 17, 2022

View reviewed changes

com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderVariables.hlsl Outdated Show resolved Hide resolved

alelievr added 2 commits February 17, 2022 19:23

Fix default smoothness value

c261c15

use macro to test depth 0

810a3c5

sebastienlagarde approved these changes Feb 18, 2022

View reviewed changes

Merge branch 'master' into sg/fullscreen-target

e07a300

sebastienlagarde merged commit 9d186e5 into master Feb 18, 2022

sebastienlagarde deleted the sg/fullscreen-target branch February 18, 2022 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ShaderGraph Fullscreen Target #6943

ShaderGraph Fullscreen Target #6943

alelievr commented Feb 1, 2022 •

edited

Loading

jessebarker commented Feb 14, 2022

esmelusina commented Feb 14, 2022

alelievr commented Feb 15, 2022

TomasKiniulis left a comment

esmelusina commented Feb 16, 2022

TomasKiniulis commented Feb 17, 2022

esmelusina left a comment

sebastienlagarde Feb 17, 2022

alelievr commented Feb 17, 2022

ShaderGraph Fullscreen Target #6943

ShaderGraph Fullscreen Target #6943

Conversation

alelievr commented Feb 1, 2022 • edited Loading

Purpose of this PR

jessebarker commented Feb 14, 2022

esmelusina commented Feb 14, 2022

alelievr commented Feb 15, 2022

TomasKiniulis left a comment

Choose a reason for hiding this comment

esmelusina commented Feb 16, 2022

TomasKiniulis commented Feb 17, 2022

esmelusina left a comment

Choose a reason for hiding this comment

sebastienlagarde Feb 17, 2022

Choose a reason for hiding this comment

alelievr commented Feb 17, 2022

alelievr commented Feb 1, 2022 •

edited

Loading