Read-only TextInput text is invisible #6708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. VFX Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
VladNeykov
approved these changes
Jan 11, 2022
# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
…//github.com/Unity-Technologies/Graphics into vfx/fix/1387237-invisible-text-when-disabled # Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
julienamsellem
deleted the
vfx/fix/1387237-invisible-text-when-disabled
branch
julienf-unity
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Fixed regression due to recent TextInput refactoring in UIToolkit * Updated changelog
matteblair
pushed a commit
to Pontoco/Graphics
that referenced
this pull request
Sep 7, 2022
Jira ticket: https://jira.unity3d.com/browse/UUM-9227 Original PR: Unity-Technologies#6708 Original FB: https://fogbugz.unity3d.com/f/cases/1387237/ Some recent changes in UIToolkit made our read-only TextInput unreadable because of the opacity being set to all disabled elements in the UI hierarchy instead of only to the leaf. [Before]  [After] 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1387237/
Some recent changes in UIToolkit made our read-only TextInput unreadable because of the opacity being set to all disabled elements in the UI hierarchy instead of only to the leaf.
[Before]
[After]
Testing status
Checked for operators connected together and for operator connected to a block.
Comments to reviewers
The risks are really limited since the change should affect only "ports".