Merge pull request #15 from finn-no/fix-install

Fix install

.travis.yml

@@ -6,6 +6,7 @@ node_js:
 script:
 - npm install
 - npm run lint
+- npm run build
 - npm run coverage
 after_success: npm run coveralls
 notifications:

examples/custom_strategy.js

@@ -13,7 +13,7 @@ class ActiveForUserWithEmailStrategy extends Strategy {
 
 const client = initialize({
     url: 'http://unleash.herokuapp.com/features',
-    refreshIntervall: 10000,
+    refreshInterval: 10000,
     strategies: [new ActiveForUserWithEmailStrategy()],
 });
 

package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "lint": "eslint .",
     "build": "tsc src/*.ts -d --strictNullChecks --sourceMap --outdir ./lib --lib ES6,ES5",
-    "postinstall": "npm run build",
+    "prepublish": "not-in-install && npm run build || in-install",
     "test": "ava test",
     "coverage": "nyc --check-coverage=true npm test",
     "coveralls": "nyc report --reporter=text-lcov | coveralls"
@@ -29,7 +29,7 @@
     "request": "^2.74.0"
   },
   "engines": {
-    "node": "6"
+    "node": ">=6"
   },
   "files": [
     "lib",
@@ -42,6 +42,7 @@
     "coveralls": "^2.11.2",
     "eslint": "^3.3.1",
     "eslint-config-finn": "^1.0.0-alpha.9",
+    "in-publish": "^2.0.0",
     "mkdirp": "^0.5.1",
     "nock": "^1.2.1",
     "nyc": "^8.3.0",

src/repository.ts

@@ -11,7 +11,7 @@ export default class Repository extends EventEmitter implements EventEmitter {
     private storage: Storage;
     private etag: string;
 
-    constructor (backupPath: string, url: string, refreshIntervall?: number, StorageImpl = Storage) {
+    constructor (backupPath: string, url: string, refreshInterval?: number, StorageImpl = Storage) {
         super();
         if (!url.startsWith('http')) {
             throw new Error(`Wrong url: ${url}`);
@@ -24,8 +24,8 @@ export default class Repository extends EventEmitter implements EventEmitter {
 
         process.nextTick(() => this.fetch());
 
-        if (refreshIntervall != null && refreshIntervall > 0) {
-            this.timer = setInterval(() => this.fetch(), refreshIntervall);
+        if (refreshInterval != null && refreshInterval > 0) {
+            this.timer = setInterval(() => this.fetch(), refreshInterval);
             this.timer.unref();
         }
     }
@@ -61,7 +61,7 @@ export default class Repository extends EventEmitter implements EventEmitter {
             }
 
             if (res.statusCode !== 200) {
-                return this.emit('error', new Error('Reponse was not statusCode 200'));
+                return this.emit('error', new Error('Response was not statusCode 200'));
             }
 
             try {

src/unleash.ts

@@ -10,7 +10,7 @@ const BACKUP_PATH: string = tmpdir();
 
 export interface UnleashConfig {
     url: string;
-    refreshIntervall?: number;
+    refreshInterval?: number;
     backupPath?: string;
     strategies: Strategy[];
     errorHandler?: (err: any) => any;
@@ -23,7 +23,7 @@ export class Unleash extends EventEmitter {
 
     constructor({
         url,
-        refreshIntervall = 15 * 1000,
+        refreshInterval = 15 * 1000,
         backupPath = BACKUP_PATH,
         strategies = [],
         errorHandler = () => {}
@@ -34,7 +34,7 @@ export class Unleash extends EventEmitter {
             throw new Error('Unleash server URL missing');
         }
 
-        this.repository = new Repository(backupPath, url, refreshIntervall);
+        this.repository = new Repository(backupPath, url, refreshInterval);
 
         this.repository.on('error', (err) => {
             this.emit('error', err);
@@ -58,7 +58,7 @@ export class Unleash extends EventEmitter {
             return this.client.isEnabled(name, context, fallbackValue);
         } else {
             const returnValue = typeof fallbackValue === 'boolean' ? fallbackValue : false;
-            this.emit('warn', `Unleash has not been initalized yet. isEnabled(${name}) defaulted to ${returnValue}`);
+            this.emit('warn', `Unleash has not been initialized yet. isEnabled(${name}) defaulted to ${returnValue}`);
             return returnValue;
         }
     }

test/client.test.js

@@ -170,7 +170,7 @@ test('should emit error when invalid feature runtime', (t) => {
             return {
                 name: 'feature-wrong-strategy',
                 enabled: true,
-                strategies: [{ name: 'non-existant' }],
+                strategies: [{ name: 'non-existent' }],
             };
         },
     };

test/repository.test.js

@@ -117,7 +117,7 @@ test.cb('should handle 404 request error and emit error event', (t) => {
 
     repo.on('error', (err) => {
         t.truthy(err);
-        t.true(err.message.startsWith('Reponse was not statusCode 200'));
+        t.true(err.message.startsWith('Response was not statusCode 200'));
         t.end();
     });
 });
@@ -138,7 +138,7 @@ test('should handle invalid JSON response', (t) => new Promise((resolve, reject)
     const url = 'http://unleash-test-7.app';
     nock(url).persist()
         .get('/features')
-        .reply(200, '{"INvalid payload');
+        .reply(200, '{"Invalid payload');
     const repo = new Repository('foo', `${url}/features`, 0, MockStorage);
     repo.on('error', (err) => {
         t.truthy(err);

test/storage.test.js

@@ -16,7 +16,7 @@ function setup (name) {
     return storage;
 }
 
-test('should load content from backupfile', (t) => new Promise((resolve, reject) => {
+test('should load content from backup file', (t) => new Promise((resolve, reject) => {
     const tmp = join(tmpdir(), 'backup-file-test');
     mkdirp.sync(tmp);
     const storage = new Storage(tmp);
@@ -37,7 +37,7 @@ test('should load content from backupfile', (t) => new Promise((resolve, reject)
 }));
 
 
-test.cb('should emit error when non-existant target backupPath', (t) => {
+test.cb('should emit error when non-existent target backupPath', (t) => {
     const storage = new Storage(join(tmpdir(), `random-${Math.round(Math.random() * 10000)}`));
     storage.reset({ random: Math.random() });
     storage.on('error', (err) => {
@@ -59,7 +59,7 @@ test.cb('should emit error when stored data is invalid', (t) => {
     });
 });
 
-test('should not write content from backupfile if ready has been fired', (t) => new Promise((resolve, reject) => {
+test('should not write content from backup file if ready has been fired', (t) => new Promise((resolve, reject) => {
     const tmp = join(tmpdir(), 'ignore-backup-file-test');
     mkdirp.sync(tmp);
     const storage = new Storage(tmp);

test/unleash.test.js

@@ -98,7 +98,7 @@ test('should consider unknown feature-toggle as disabled', (t) => new Promise((r
 }));
 
 
-test('should return fallbackvalue until online', (t) => new Promise((resolve, reject) => {
+test('should return fallback value until online', (t) => new Promise((resolve, reject) => {
     mockNetwork();
     const instance = new Unleash({
         url: 'http://unleash.app/features',