Fix install #15
Merged
Fix install #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Oct 11, 2016
| @@ -29,7 +29,7 @@ | |||
| "request": "^2.74.0" | |||
| }, | |||
| "engines": { | |||
| "node": "6" | |||
| "node": ">=6" | |||
There was a problem hiding this comment.
You test on node 4, though, why lock it to 6?
SimenB
commented
Oct 11, 2016
| @@ -11,7 +11,7 @@ export default class Repository extends EventEmitter implements EventEmitter { | |||
| private storage: Storage; | |||
| private etag: string; | |||
|
|
|||
| constructor (backupPath: string, url: string, refreshIntervall?: number, StorageImpl = Storage) { | |||
| constructor (backupPath: string, url: string, refreshInterval?: number, StorageImpl = Storage) { | |||
There was a problem hiding this comment.
Breaking change, I suppose...
There was a problem hiding this comment.
New client is breaking, so fine to fix this as well.
SimenB
commented
Oct 11, 2016
| @@ -13,7 +13,7 @@ class ActiveForUserWithEmailStrategy extends Strategy { | |||
|
|
|||
| const client = initialize({ | |||
| url: 'http://unleash.herokuapp.com/features', | |||
| refreshIntervall: 10000, | |||
| refreshInterval: 10000, | |||
There was a problem hiding this comment.
Seeing as this typo was present in the old version as well, maybe we should do something like
console.log('Passed in `refreshIntervall`, please use `refreshInterval` instead');and map it? Making migration from old to new easier
|
Add a console.log, and this is fine to merge and release another alpha. |
|
Just log, or map it over from the old name as well? EDIT: nvm, saw the other comment |
|
On second thought, this is a breaking change, lets throw instead as its startup time. |
|
Kk! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, it fails on install with:
If I install typescript, it still fails because the source code is not included in the package.
Also allow this to be run on Node@7 without warnings (release imminent)
/cc @sveisvei @ivarconr