Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the latest version of the research app in the frontend #352

Merged
merged 10 commits into from
May 25, 2023

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented May 25, 2023

This gets the fix for HiPS loading over HTTPS.

Overview

This gets the fix for the issue described in WorldWideTelescope/wwt-webgl-engine#249 .

Checklist

  • [N/A] Changed code has some test coverage (or justify why not)
  • [N/A] Changes in functionality documented (or justify why not)

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #352 (a13d7b6) into master (ef9deae) will not change coverage.
The diff coverage is n/a.

❗ Current head a13d7b6 differs from pull request most recent head 4c76293. Consider uploading reports for the commit 4c76293 to get more accurate results

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   56.39%   56.39%           
=======================================
  Files          25       25           
  Lines        2848     2848           
=======================================
  Hits         1606     1606           
  Misses       1242     1242           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pkgw pkgw merged commit 26c3ebd into WorldWideTelescope:master May 25, 2023
@pkgw pkgw deleted the update-deps branch May 25, 2023 23:16
pkgw added a commit to Carifio24/pywwt that referenced this pull request May 1, 2024
As seen in WorldWideTelescope#375, the workaround added in WorldWideTelescope#352 may be causing problems
now. I don't recall exactly what the issue was before, but we don't
use brotli, so as a first step let's just get rid of the install
command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant