Update HiPS URL and message handler setup #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address an issue discovered while trying to run CosmicDS in an environment with restrictive (i.e. HTTPS-only) internet. The issue is that we use an HTTP URL for the HiPS WTML, together with the fact that message handlers aren't properly set up if the collection load here fails.
This attempts to address the issue by:
finally
block for the HiPS collection load. In the case that load fails, a query script that wants to set up HiPS catalogs won't be able to do so, but that was already going to be the case anyways.then
->finally
.