Remove all_perform callbacks #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a slight adjustment to when we run the deferred after_perform callbacks, we can achieve the same ordering by using after_perform as we had with after_all_perform.
These turned out to be redundant since Organizer already implements 'perform' callbacks. I had to where the deferred callbacks get run so that the timing is the same when using after_perform as it was for all_perform.
|
@aaronmallen Only took me a year to realize this part isn't necessary 😅. This PR removes those callbacks entirely...I figure it's easy to swap out |
|
I'm working on a breaking change for this gem and this is a breaking change itself. I think for 1.x we're going to leave this functionality in, redundant or not. I appreciate the correction though! |
mjonas87
commented
Sep 22, 2023
|
|
||
| if context&.success? && interactor.respond_to?(:run_after_perform_callbacks_on_children) | ||
| interactor.run_after_perform_callbacks_on_children | ||
| end |
There was a problem hiding this comment.
@aaronmallen if I leave the callbacks in are you okay with a PR that includes just this change to move where the deferred callbacks get executed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I introduced the
all_performcallbacks for Organizers, it didn't occur to me that theperformcallbacks already do the same thing (since an Organizer is an Interactor).The only problem with that was a dependency I introduced for running deferred
after_performcallbacks that ran these based on theall_performcallbacks. I moved this logic to run after theperformcallbacks and everything seems to be working as expected.I also updated some of the specs so that they're a bit easier to read and update.
Information
Related Issues
none
TODO
none
Changelog
Removed
all_performcallback for Organizers. Please use theperformcallbacks instead.