Defer until after perform instead of all_perform
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all_perform was a redundant callbacks and is entirely enveloped by the Organizer's `perform` callbacks. This change moves the execution of the deferred callbacks to after `perform` rather than `all_perform` to better match the intent of the `defer_after_callbacks_when_organized` attribute.
|
@aaronmallen This fix was bundled up in the breaking change I submitted previously. Pulled out the breaking change. |
aaronmallen
approved these changes
Sep 30, 2023
|
Thank you! |
|
Thanks for your contribution, this has been released in v1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
all_performis a redundant set of callbacks and is entirely enveloped by the Organizer'sperformcallbacks. This change moves the execution of the deferred callbacks to afterperformrather thanall_performto better match the intent of thedefer_after_callbacks_when_organizedattribute.The impact of this should be very minimal as, in both cases, the callbacks are still deferred until after all nested interactors have finished.
Information
[ ] Contains DocumentationIt's a bug fix for logic that is already documented.[ ] Contains TestsLeft tests unmodified to validate it is not a breaking change[ ] Contains Breaking ChangesDoes not.Changelog
Fixed
after_performcallbacks are run.