Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support latest as a version alias for the latest Node version #257

Closed
TomasHubelbauer opened this issue Apr 22, 2021 · 4 comments
Closed

Support latest as a version alias for the latest Node version #257

TomasHubelbauer opened this issue Apr 22, 2021 · 4 comments
Assignees
@panticmilos
Labels
feature request New feature or request to improve the current logic

Comments

@TomasHubelbauer
Copy link

#26 discusses supporting several types of aliases. That discussion has been going on for a long time. It seems the main complications revolve around how to deal with lts.

For those of us who don't care about lts and just want latest so that we can test that our work works on latest Node automatically, could we please get support for latest first and let #26 focus on the subtleties of lts and how to implement that? It seems like these two aliases do not need to be grouped into a single feature release, in fact, it looks, like implementing them separately would simplify things and potentially make it possible to provide latest soon.
@TomasHubelbauer TomasHubelbauer mentioned this issue Apr 22, 2021
Closed
@chriszs chriszs mentioned this issue May 13, 2021
Merged
4 tasks
JonathanLeeWH added a commit to learnsoftwaredevelopment/SoftwareRepository that referenced this issue May 26, 2021
@JonathanLeeWH
Amended dockerfile, dockerfile-ci to use nodejs LTS version
31fa14d 
Amended Readme.md removing unnecessary brackets and update Nodejs to Nodejs LTS
Amended GitHub Actions node.js.yml to use nodejs lts version 14 (As of 26 May 2021 as currently there are still some issues supporting `lts` alias  in `setup-node` GitHub Action which is a known issue: actions/setup-node#26 actions/setup-node#257)
@JonathanLeeWH JonathanLeeWH mentioned this issue May 26, 2021
Merged
@voxpelli voxpelli mentioned this issue Jun 30, 2021
Closed
@theoludwig theoludwig mentioned this issue Jul 1, 2021
Closed
@theoludwig
Copy link

Good news!
I opened a PR to allow the current alias. 👍
We can maybe support both current and latest aliases but I find it more convenient to use the current keyword as it is how Node.js names their versions.

PR available there: #279

@Nargonath Nargonath mentioned this issue Nov 19, 2021
Closed
@dmitry-shibanov dmitry-shibanov added the feature request New feature or request to improve the current logic label Dec 13, 2021
@panticmilos panticmilos mentioned this issue Apr 21, 2022
Closed
@zdm
Copy link

zdm commented Apr 21, 2022

1 year of discussions, do we have a chance?

@panticmilos
Copy link
Contributor

Hi @zdm,

Yes, this feature is under development.

@dmitry-shibanov
Copy link
Contributor

Hello everyone, we released a new version of the setup-node action with support of latest alias. For now I'm going to close the issue. If you have any concerns feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panticmilos panticmilos

Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for current and latest aliases
5 participants
@zdm @TomasHubelbauer @theoludwig @dmitry-shibanov @panticmilos