Skip to content

Commit

Permalink
Amended dockerfile, dockerfile-ci to use nodejs LTS version
Browse files Browse the repository at this point in the history
Amended Readme.md removing unnecessary brackets and update Nodejs to Nodejs LTS
Amended GitHub Actions node.js.yml to use nodejs lts version 14 (As of 26 May 2021 as currently there are still some issues supporting `lts` alias  in `setup-node` GitHub Action which is a known issue: actions/setup-node#26 actions/setup-node#257)
  • Loading branch information
JonathanLeeWH committed May 26, 2021
1 parent 204ce94 commit 31fa14d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [12.x]
node-version: [14.x]

steps:
- uses: actions/checkout@v2.3.4
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# With comments to aid in my learning of docker.

# To use official nodejs base docker image.
FROM node:12
FROM node:lts

# The working directory where any subsequent instructions in the Dockerfile will be executed on.
WORKDIR /app
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-ci
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# With comments to aid in my learning of docker.

# To use official nodejs base docker image.
FROM node:12
FROM node:lts

# The working directory where any subsequent instructions in the Dockerfile will be executed on.
WORKDIR /app
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[![MIT License](https://img.shields.io/badge/license-MIT-blue)](https://github.com/learnsoftwaredevelopment/SoftwareRepository/blob/master/LICENSE)
![GitHub Node.js CI](https://github.com/learnsoftwaredevelopment/SoftwareRepository/workflows/Node.js%20CI/badge.svg?branch=master)
![App Container CI](https://github.com/learnsoftwaredevelopment/SoftwareRepository/actions/workflows/app-test-container-no-docker-cache.yml/badge.svg?branch=master)]
![App Container CI](https://github.com/learnsoftwaredevelopment/SoftwareRepository/actions/workflows/app-test-container-no-docker-cache.yml/badge.svg?branch=master)

## Introduction

Expand Down Expand Up @@ -169,7 +169,7 @@ A list of the technologies and frameworks used in this project

### Backend Technologies

- Node.js (Node 12)
- Node.js (Node.js LTS)
- MongoDB
- Firebase Authentication

Expand Down

0 comments on commit 31fa14d

Please sign in to comment.