Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import deprecate from @ember/debug #367

Conversation

ndekeister-us
Copy link
Contributor

@ndekeister-us ndekeister-us commented Aug 3, 2021

Same issue than the one on emberjs/ember-test-helpers#1066, in canary import { deprecate } from '@ember/application/deprecations' don't work anymore, replaced it by import { deprecate } from '@ember/debug';

When running test on ember-canary scenario, it is failing (job timeout) with this error

Global error: Uncaught Error: Could not find module `@ember/application/deprecations` imported from `dummy/initializers/flash-messages`

@ndekeister-us
Copy link
Contributor Author

Hmm so ci/circleci:tests job is failing on this repo for canary scenario with this error

not ok 1 Chrome 92.0 - [undefined ms] - Global error: Uncaught Error: Could not find module `@ember/application/deprecations` imported from `@ember/test-helpers/setup-rendering-context` at http://localhost:7357/assets/vendor.js, line 259

...

Too long with no output (exceeded 10m0s): context deadline exceeded

It is (as funny as it sounds) the same issue linked on the PR description -> https://github.com/emberjs/ember-test-helpers/pull/1066/files

If i'm not wrong it is because, on this repo, @ember/test-helpers is added via ember-qunit@^4.6.0 dependencies and resolved to 1.7.x

We will also have to run ember-cli-update on https://github.com/poteto/ember-cli-flash/ so that it update to a recent version of ember, in which @ember/test-helpers have to be added as devDependencies to the project (see https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md#qunit-and-embertest-helpers-dependencies)

@ndekeister-us ndekeister-us mentioned this pull request Aug 3, 2021
@ndekeister-us
Copy link
Contributor Author

Closing, will be done in #365

@ndekeister-us ndekeister-us deleted the fix/import_for_ember-canary branch November 8, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant