Correctly import deprecate from @ember/debug
#1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Canary still fails because of: |
|
Nice, thanks for the quick fix here @mydea 👍 I am also seeing basically any addon test suite failing on canary. Strangely the GH Actions job is not failing immediately, but timing out after running >5h! 🙈. So for both addon maintainers and Github container utilization getting this landed would be very helpful! 😆 |
|
I just experienced the same thing, but I have my timeout set much lower :) |
|
Thanks! |
|
Any chance you could cut a release with this change? Would be great to get canary tests passing again for addons :) |
buschtoens
added a commit
to buschtoens/ember-service-helper
that referenced
this pull request
Jul 27, 2021
buschtoens
added a commit
to buschtoens/ember-service-helper
that referenced
this pull request
Jul 27, 2021
This was referenced Aug 3, 2021
jherdman
added a commit
to evoactivity/ember-svg-jar
that referenced
this pull request
Oct 1, 2021
jherdman
added a commit
to evoactivity/ember-svg-jar
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was incorrectly imported from
@ember/application/deprecations, which seemed to work, but does not work in current canary - I got this error in an addon testing on canary:Anyway, even if this might/should be fixed in canary, the import is wrong and can be updated to the correct place.