Stampit removal on contract compiler #1523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkaintas
force-pushed
the
stampit-drop-contract
branch
from
4d34b1b
to
2f00f7b
Compare
|
This pull request introduces 2 alerts and fixes 1 when merging 2f00f7b into d42c90d - view on LGTM.com new alerts:
fixed alerts:
|
|
I am resolving the merge conflicts. |
davidyuk
reviewed
May 25, 2022
| @@ -145,9 +145,9 @@ describe('Contract instance', function () { | |||
|
|
|||
| before(async function () { | |||
| aeSdk = await getSdk() | |||
| testContractAci = await aeSdk.compilerApi | |||
| testContractAci = await aeSdk.contractCompiler.compilerApi | |||
There was a problem hiding this comment.
the approach looks good, but I would combine ContractCompilerHttp and CompilerApi, to have just:
Suggested change
| testContractAci = await aeSdk.contractCompiler.compilerApi | |
| testContractAci = await aeSdk.compilerApi |
There was a problem hiding this comment.
Other than the compilerApi property, ContractCompilerHttp also has other properties and methods, specifically compilerVersion and setCompilerUrl. How would we access those if ContractCompilerHttp was to become one with compilerApi?
martinkaintas
force-pushed
the
stampit-drop-contract
branch
from
b2937e1
to
b154df4
Compare
davidyuk
force-pushed
the
develop
branch
3 times, most recently
from
7db7a95
to
d3f7904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1524
Based on: #1511