refactor(ae): remove stamps and migrate to TypeScript #1547
Conversation
|
This pull request introduces 1 alert and fixes 11 when merging 756bb32 into 5c74af3 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 11 when merging dfbd1f9 into 5c74af3 - view on LGTM.com new alerts:
fixed alerts:
|
src/ae/index.ts
Outdated
| const instanceOptions = { | ||
| ...this.Ae.defaults, | ||
| onNode: this.selectedNode.instance, | ||
| instance: this, |
There was a problem hiding this comment.
instance shouldn't be passed here
There was a problem hiding this comment.
The problem is with onAccount. Basically, there are cases where onAccount has a different value, for example in the transferFunds test: https://github.com/aeternity/aepp-sdk-js/blob/develop/test/integration/accounts.js#L103
onAccount is a reserved word. Therefore, when in need to call this functions inside transferFunds, error occurs.
A workaround is to use a different keyword, thus instance.
|
This pull request fixes 11 alerts when merging c78475d into 0b6b9bb - view on LGTM.com fixed alerts:
|
|
This pull request fixes 11 alerts when merging 728b828 into 0b6b9bb - view on LGTM.com fixed alerts:
|
davidyuk
force-pushed
the
develop
branch
2 times, most recently
from
0810699
to
6d5b7bd
Compare
Kalovelo
force-pushed
the
feature/ts-ae
branch
3 times, most recently
from
7c71254
to
95b3277
Compare
|
This pull request introduces 2 alerts and fixes 1 when merging 95b3277 into 6d5b7bd - view on LGTM.com new alerts:
fixed alerts:
|
|
@davidyuk updated & rebased, only issue is with 2 specific test cases |
BREAKING CHANGE: `name.update`, `name.revoke` doesn't accept account as string anymore Pass an instance of AccountBase to `onAccount` option instead.
|
This pull request introduces 4 alerts when merging 8ed55d0 into cdb95d4 - view on LGTM.com new alerts:
|
based on #1510, closes #1517
As you can see, some stamps have been left (NodePool, AccountResolver, ContractCompilerHttp, AccountMultiple) because they are removed in pending PRs (#1522, #1523)