Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop raise_for_status() releasing when in a context #9239

Merged
merged 11 commits into from
Sep 23, 2024

Conversation

Dreamsorcerer
Copy link
Member

Fixes #8451.

@Dreamsorcerer Dreamsorcerer added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 22, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 22, 2024
CHANGES/9239.bugfix.rst Outdated Show resolved Hide resolved
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
CHANGES/9239.bugfix.rst Outdated Show resolved Hide resolved
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
CHANGES/9239.bugfix.rst Outdated Show resolved Hide resolved
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (3c1ca45) to head (2c56bb0).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9239   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files         107      107           
  Lines       34699    34741   +42     
  Branches     4111     4121   +10     
=======================================
+ Hits        34152    34194   +42     
  Misses        380      380           
  Partials      167      167           
Flag Coverage Δ
CI-GHA 98.31% <100.00%> (-0.01%) ⬇️
OS-Linux 97.97% <100.00%> (-0.01%) ⬇️
OS-Windows 96.36% <100.00%> (-0.01%) ⬇️
OS-macOS 97.65% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.74% <100.00%> (-0.02%) ⬇️
Py-3.10.15 97.67% <100.00%> (-0.02%) ⬇️
Py-3.11.10 97.57% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.64% <100.00%> (-0.01%) ⬇️
Py-3.12.6 98.03% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.63% <100.00%> (-0.02%) ⬇️
Py-3.9.20 97.57% <100.00%> (-0.02%) ⬇️
Py-pypy7.3.16 97.18% <100.00%> (-0.02%) ⬇️
VM-macos 97.65% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.97% <100.00%> (-0.01%) ⬇️
VM-windows 96.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 63cfd5f into master Sep 23, 2024
34 of 35 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-raise-in-context branch September 23, 2024 00:05
Copy link
Contributor

patchback bot commented Sep 23, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 63cfd5f on top of patchback/backports/3.10/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239

Backporting merged PR #9239 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239 upstream/3.10
  4. Now, cherry-pick PR Stop raise_for_status() releasing when in a context #9239 contents into that branch:
    $ git cherry-pick -x 63cfd5f96b3ce819c7feac67dfa4183ac4731acd
    If it'll yell at you with something like fatal: Commit 63cfd5f96b3ce819c7feac67dfa4183ac4731acd is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 63cfd5f96b3ce819c7feac67dfa4183ac4731acd
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Stop raise_for_status() releasing when in a context #9239 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Sep 23, 2024

Backport to 3.11: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 63cfd5f on top of patchback/backports/3.11/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239

Backporting merged PR #9239 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.11/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239 upstream/3.11
  4. Now, cherry-pick PR Stop raise_for_status() releasing when in a context #9239 contents into that branch:
    $ git cherry-pick -x 63cfd5f96b3ce819c7feac67dfa4183ac4731acd
    If it'll yell at you with something like fatal: Commit 63cfd5f96b3ce819c7feac67dfa4183ac4731acd is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 63cfd5f96b3ce819c7feac67dfa4183ac4731acd
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Stop raise_for_status() releasing when in a context #9239 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.11/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Dreamsorcerer added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow reading already retrieved response body after connection is closed
3 participants