Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop raise_for_status() releasing when in a context (#9239) #9256

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit 63cfd5f)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (76284b5) to head (20a7768).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9256   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files         108      108           
  Lines       34745    34771   +26     
  Branches     4150     4155    +5     
=======================================
+ Hits        33979    34005   +26     
  Misses        573      573           
  Partials      193      193           
Flag Coverage Δ
CI-GHA 97.69% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.37% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.96% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.09% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.99% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.59% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.88% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.05% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.00% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.60% <100.00%> (+<0.01%) ⬆️
VM-macos 97.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.37% <100.00%> (+<0.01%) ⬆️
VM-windows 94.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 5fe6325 into 3.10 Sep 23, 2024
33 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/63cfd5f96b3ce819c7feac67dfa4183ac4731acd/pr-9239 branch September 23, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant