Add typing to URL

[bdraco]

What do these changes do?

Add typing to URL

Are there changes in behavior for the user?

no runtime changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (d4e7601) to head (24768b8).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   93.06%   94.88%   +1.82%     
==========================================
  Files          31       30       -1     
  Lines        4424     4358      -66     
  Branches      370      382      +12     
==========================================
+ Hits         4117     4135      +18     
+ Misses        281      197      -84     
  Partials       26       26              

Flag	Coverage Δ
CI-GHA	94.83% <100.00%> (+1.82%)	⬆️
MyPy	38.91% <97.50%> (+11.94%)	⬆️
OS-Linux	99.34% <99.12%> (+<0.01%)	⬆️
OS-Windows	99.44% <99.12%> (+<0.01%)	⬆️
OS-macOS	99.02% <99.12%> (+<0.01%)	⬆️
Py-3.10.11	98.90% <98.24%> (-0.03%)	⬇️
Py-3.10.14	99.16% <98.24%> (-0.03%)	⬇️
Py-3.11.9	99.16% <98.24%> (-0.03%)	⬇️
Py-3.12.5	99.16% <98.24%> (-0.03%)	⬇️
Py-3.13.0-rc.1	99.16% <98.24%> (-0.03%)	⬇️
Py-3.8.10	98.85% <98.24%> (-0.03%)	⬇️
Py-3.8.18	99.11% <98.24%> (-0.03%)	⬇️
Py-3.9.13	98.85% <98.24%> (-0.03%)	⬇️
Py-3.9.19	99.11% <98.24%> (-0.03%)	⬇️
Py-pypy7.3.11	99.16% <98.24%> (-0.03%)	⬇️
Py-pypy7.3.16	99.19% <98.24%> (-0.03%)	⬇️
VM-macos-latest	99.02% <99.12%> (+<0.01%)	⬆️
VM-ubuntu-latest	99.34% <99.12%> (+<0.01%)	⬆️
VM-windows-latest	99.44% <99.12%> (+<0.01%)	⬆️
pytest	99.34% <99.12%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

path shows 100% diff hit on codecov but is reporting at 99.13% here...

https://app.codecov.io/gh/aio-libs/yarl/pull/1084?flags%5B0%5D=pytest&dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr%20comments&utm_term=aio-libs

[webknjaz]

path shows 100% diff hit on codecov but is reporting at 99.13% here...

Yeah, I suppose this was due to the proportion being different because the overall number of lines changed. I'm not seeing 99.13% there, though. Perhaps, it processed more reports after your comment.
For me, it shows 94.94% for the entire pytest flag and 99.88% for tests/ flagged with pytest and 98.15% for yarl/+pytest.

I suppose, it's okay to raise the codecov/project/lib expectation to 98.1% (leaving that 0.05% margin for future line count changes, until we can go for 100%).

[bdraco]

I'm going to do a RC0 release so I can run this in the CI of a few projects since typing changes are always hard to predict the impact

[sergeniushpe]

Hello, I think this change broke python 3.8 support:

../lib/python3.8/site-packages/yarl/_url.py:606: in URL
    def query(self) -> MultiDictProxy[str]:
E   TypeError: 'type' object is not subscriptable

If I downgrade to release 1.9.7 it works again.

You might want to update python requirements to indicate python>=3.9 is required

[bdraco]

Hello, I think this change broke python 3.8 support:

../lib/python3.8/site-packages/yarl/_url.py:606: in URL
    def query(self) -> MultiDictProxy[str]:
E   TypeError: 'type' object is not subscriptable

If I downgrade to release 1.9.7 it works again.

You might want to update python requirements to indicate python>=3.9 is required

Would you please open an issue report, I will fix it shortly

[bdraco]

Please include the multi dict version you are using in the issue

[Dreamsorcerer]

Please include the multi dict version you are using in the issue

As far as I can see, multidict has supported that syntax for ~6 years...
But, maybe we should increase the minimum version of multidict that yarl supports.

[bdraco]

I had to take the python 3.8 install back to multidict 4 to get it to fail. There might be a newer version that fails though as I stopped trying them once I confirmed the issue. Also even with 4 it didn’t fail on python 3.9 so I suspect the issue will go away on its own soon when we drop 3.8