-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧪 Integrate covdefaults
into coverage.py
#1085
Merged
webknjaz
merged 4 commits into
aio-libs:master
from
webknjaz:maintenance/coverage-py-codecov
Sep 3, 2024
Merged
🧪 Integrate covdefaults
into coverage.py
#1085
webknjaz
merged 4 commits into
aio-libs:master
from
webknjaz:maintenance/coverage-py-codecov
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
added
the
bot:chronographer:skip
This PR does not need to include a change note
label
Sep 2, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 92.97% 93.05% +0.08%
==========================================
Files 31 31
Lines 4414 4408 -6
Branches 370 364 -6
==========================================
- Hits 4104 4102 -2
+ Misses 284 280 -4
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
force-pushed
the
maintenance/coverage-py-codecov
branch
3 times, most recently
from
September 3, 2024 00:06
ddb09d1
to
3705f77
Compare
webknjaz
commented
Sep 3, 2024
webknjaz
force-pushed
the
maintenance/coverage-py-codecov
branch
2 times, most recently
from
September 3, 2024 00:25
cbe4f69
to
8d0ed4b
Compare
This overrides the 100% `fail_under` value coming from `covdefaults`. It's needed because some tests are impossible to run in some runtimes.
webknjaz
force-pushed
the
maintenance/coverage-py-codecov
branch
from
September 3, 2024 00:29
8d0ed4b
to
d4210cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
$sbj.
Are there changes in behavior for the user?
Nope.
Related issue number
#1084 (comment)
Checklist