Propagate gRPC status code when not ok #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrambek
reviewed
Oct 16, 2023
.../src/main/java/io/aklivity/zilla/runtime/binding/grpc/internal/stream/GrpcClientFactory.java
Show resolved
Hide resolved
.../src/main/java/io/aklivity/zilla/runtime/binding/grpc/internal/stream/GrpcClientFactory.java
Show resolved
Hide resolved
akrambek
reviewed
Oct 23, 2023
| write notify SENT_ASYNC_REQUEST | ||
| read closed | ||
|
|
||
| connect await SENT_ASYNC_REQUEST |
There was a problem hiding this comment.
Why it is called ASYNC as far as I know there is no such terminology in grpc as well
There was a problem hiding this comment.
Async over a pair of Kafka topics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When gRPC response status code arrives in HTTP response headers (not trailers), typically due to being an error of some kind (not OK status), then make sure it is conveyed consistently back to the gRPC client.
Fixes #504