Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate gRPC status code when not ok #519

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Propagate gRPC status code when not ok #519

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4e322a5
Integrate inline catalog and json validator with mqtt binding
jfallows Sep 26, 2023
8eb7dc0
Merge branch 'aklivity:develop' into develop
jfallows Sep 26, 2023
41edee0
Merge branch 'aklivity:develop' into develop
jfallows Oct 5, 2023
bafc994
Merge branch 'aklivity:develop' into develop
jfallows Oct 11, 2023
c27c7d3
Update initial flow control consistently
jfallows Oct 16, 2023
0c148ea
Send reply abort instead of initial reset, as initial stream might ha…
jfallows Oct 16, 2023
6cdd2c9
Extract status header value to use for grpc status on reply abort
jfallows Oct 16, 2023
47ff4d4
Scenarios for grpc client receiving error status
jfallows Oct 23, 2023
83b5435
Scenarios for explicit error status
jfallows Oct 23, 2023
a30d375
Scenario for client response missing status
jfallows Oct 23, 2023
fb92bab
Prevent flow control race condition
jfallows Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extract status header value to use for grpc status on reply abort
  • Loading branch information
@jfallows
jfallows committed Oct 16, 2023
commit 6cdd2c960b044d0405b80f98708b420082146e7c
3 changes: 2 additions & 1 deletion ...a/io/aklivity/zilla/runtime/binding/grpc/kafka/internal/stream/GrpcKafkaProxyFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,8 +1320,9 @@ protected void onKafkaData(
if (grpcStatus != null &&
!HEADER_VALUE_GRPC_OK.value().equals(grpcStatus.value().value()))
{
OctetsFW value = grpcStatus.value();
String16FW status = statusRW
.set(grpcStatus.value().buffer(), grpcStatus.offset(), grpcStatus.sizeof())
.set(value.buffer(), value.offset(), value.sizeof())
.build();
doGrpcAbort(traceId, authorization, status);
}
Expand Down
Loading