Exceptions for invalid use - review and extensions #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change saves us 8 bits in the ErrorOr<TValue> struct which leads to less execution time when an instance is copied by value. As the struct is now properly encapsulated from a Design by Contract point of view, I simply choose _errors being null as the indicator for errors not being present. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
feO2x
force-pushed
the
exceptions-for-invalid-use
branch
from
9da4708
to
61d1540
Compare
Instead of instantiating a new list every time ErrorsOrEmptyList is called with no errors being present, I reused a cached empty list. I also removed the unnecessary null-forgiving operators (the compiler uses the MemberNotNullWhenAttribute on IsError to verify that we checked for null beforehand). Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
The Value property is now properly encapsulated. When errors are present, the property getter will throw, similar to other properties like Errors or FirstError. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
When clients have <Nullable> turned off, the C# compiler won't hint that null shouldn't be passed as the errors array/list. By explicitly checking for null, we eliminate these error cases. Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
… passed Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
Signed-off-by: Kenny Pflug <kenny.pflug@live.de>
|
I'm lucky to get your help on this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Amichai,
I reviewed your exception PR and would suggest the following changes:
IsErroris now a computed property. This removes 8 bits for the boolean value from the struct which leads to less execution time when copying by value. The sole indicator is now_errorsbeing null.ErrorsOrEmptyList. This prevents allocating a new list on every property call where no errors are present.Valueproperty will now throw anInvalidOperationExceptionwhen errors are present. This behavior is now in line with the behavior of theErrorsorFirstErrorproperty.InvalidOperationExceptionthrown in the implicit conversion methods to anArgumentException- this is the usual exception that callers would expect when invalid parameters are passed in.ToErrorOrextension method for error arrays - we did not have this one beforehand, only for lists.ErrorOr<TValue>. The C# compiler will comprehend that a field is not null according to theMemberNotNullWhenAttributeinstances applied toIsError.Feel free to cherry-pick these features as you see fit.