[navbar] fix click events on sidebar toggle when using a custom svg-icon in IE11 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rigger, allows click event to propate to its wrapper element
components/navbar/navbar.css
Outdated
| @@ -137,3 +137,7 @@ | |||
| .ampstart-sidebar .ampstart-navbar-trigger { | |||
| line-height: inherit; | |||
| } | |||
|
|
|||
| .ampstart-headerbar .ampstart-navbar-trigger svg { | |||
There was a problem hiding this comment.
Just .ampstart-navbar-trigger svg should be fine. is this because the svg does not bubble up click events?
There was a problem hiding this comment.
Yes, the svg elements swallows the click events, which never bubble up
camelburrito
requested changes
Jul 19, 2017
…cons inside the navbar trigger
camelburrito
approved these changes
Jul 20, 2017
gifteconomist
pushed a commit
to metalabdesign/ampstart
that referenced
this pull request
Oct 19, 2017
…con in IE11 (ampproject#528) * fix(navbar): setting pointer-events to none when using a custom svg-trigger, allows click event to propate to its wrapper element * refactor(styles): updated selector to prevent pointer events on svg icons inside the navbar trigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue #526 .
Setting
pointer-events: noneallows the click event to propagate to its wrapper and toggle the sidebar.