Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navbar] fix click events on sidebar toggle when using a custom svg-icon in IE11 #528

Merged
merged 2 commits into from
Jul 20, 2017
Merged

[navbar] fix click events on sidebar toggle when using a custom svg-icon in IE11 #528

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c3a9ba
fix(navbar): setting pointer-events to none when using a custom svg-t…
Jul 19, 2017
f910ed8
refactor(styles): updated selector to prevent pointer events on svg i…
Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/navbar/navbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,7 @@
.ampstart-sidebar .ampstart-navbar-trigger {
line-height: inherit;
}

.ampstart-headerbar .ampstart-navbar-trigger svg {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just .ampstart-navbar-trigger svg should be fine. is this because the svg does not bubble up click events?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the svg elements swallows the click events, which never bubble up

pointer-events: none;
}