Fix resolve field type on double field types

[jackkleeman]

It is completely valid for the field type to be missing; some compiles (eg, js) will not include default enum values in the message, and in this case the default field type is double. When a double is sent currently, a missing field type error is returned. This error should never be returned. As is done elsewhere, we should use the getter instead of reading the field directly so that the default value is automatically included where needed.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (8e245d6) 75.49% compared to head (8f771d1) 75.45%.

❗ Current head 8f771d1 differs from pull request most recent head 851fe1e. Consider uploading reports for the commit 851fe1e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   75.49%   75.45%   -0.05%     
==========================================
  Files          30       30              
  Lines        5223     5214       -9     
==========================================
- Hits         3943     3934       -9     
  Misses       1280     1280              

Impacted Files	Coverage Δ
prost-reflect/src/descriptor/build/resolve.rs	67.52% <100.00%> (+0.46%)	⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[andrewhickman]

Thanks for the PR!

Please could you add a test for this case to prost-reflect/tests/main.rs or prost-reflect/src/descriptor/tests.rs?

[jackkleeman]

Sure - done @andrewhickman

[andrewhickman]

Thanks! I've published 0.10.3 with this change