Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for discovery with JS #205

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Fixes for discovery with JS #205

merged 1 commit into from
Mar 22, 2023

Conversation

jackkleeman
Copy link
Contributor

  • Patch prost-reflect
  • Add docker-compose
  • Ensure discovery only goes over http2
  • Add ca certs to the dockerfile, as the rustls library panics if it doesn't find them :(

slinkydeveloper
slinkydeveloper reviewed Mar 17, 2023
View reviewed changes
src/service_protocol/src/discovery.rs Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@slinkydeveloper
Copy link
Contributor

Looks like we can get rid of the prost-reflect patch? andrewhickman/prost-reflect#29 (comment)

tillrohrmann
tillrohrmann approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @jackkleeman. I've tried the console feature out and it works nicely :-) +1 for merging.

@jackkleeman
Fixes for discovery with JS
ee8d616 
- Patch prost-reflect
- Ensure discovery only goes over http2
- Add ca certs to the dockerfile, as the rustls library panics if it doesn't find them :(
- Add a console feature to enable tokio-console to be used
@jackkleeman jackkleeman merged commit 9280055 into restatedev:main Mar 22, 2023
@jackkleeman jackkleeman deleted the prost-reflect branch March 22, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackkleeman @slinkydeveloper @tillrohrmann