Auto populate various required lookups on various forms #8104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
|
@dsesami @tiagodread , @mabashian is going on PTO this week. I think we should give this some early feedback today. |
jlmitch5
approved these changes
Sep 14, 2020
| @@ -0,0 +1,24 @@ | |||
| import { useCallback, useRef } from 'react'; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I think we should either fill this in or get rid of the comment
| }, | ||
| [populateLookupField] | ||
| ); | ||
| } |
|
@mabashian As a normal user who has admin access to an Organization and Projects I can’t choose a project on Job template form because the lookup field is disabled. Steps to reproduce:
Result:
Expected Result:
Extra information: Instead of creating 2 projects, create only one, the project field is auto populated but still disabled |
…st as it wasn't actually testing the desired behavior.
mabashian
force-pushed
the
4254-auto-pop-lookup
branch
from
8ec072a
to
10ae6c9
Compare
|
Build succeeded.
|
tiagodread
approved these changes
Sep 21, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
link #4254
Auto populates the following fields on the following forms if the user only has access to one resource for the field in question:
In order to achieve this and make it as uniform as possible I added the useAutoPopulateLookup hook. This simple hook will trigger the callback to update the field value the first time through if enabled. This hook was added to the CredentialLookup, OrganizationLookup, and ProjectLookup components.
As a result of these changes, a lot of
onChangefunctions in various forms needed to be wrapped inuseCallbackto prevent unnecessary extra requests being triggered in the lookup. TheonChangefunction is now referenced inside the useRequest hook and as a result is in it's dependency array and shouldn't be changing with each render (hence useCallback). There was one snag with this pattern: jaredpalmer/formik#2268. TheuseFieldhelpers in Formik were causing the callback function to be re-generated with each render (and as result were causing numerous extra GET requests by the lookup components). Fortunately,setFieldValuedoes not suffer the same fate: jaredpalmer/formik#2268 (comment). So I refactored a lot of our functions to use that inside theuseCallbackhooks.Here's a quick example of what it looks like:
ISSUE TYPE
COMPONENT NAME