Add organization when creating/editing an execution environments #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSCorey
requested changes
Oct 6, 2020
awx/ui_next/src/screens/ExecutionEnvironment/shared/ExecutionEnvironmentForm.jsx
Outdated
Show resolved
Hide resolved
awx/ui_next/src/screens/ExecutionEnvironment/shared/ExecutionEnvironmentForm.jsx
Outdated
Show resolved
Hide resolved
| : () => undefined, | ||
| }); | ||
|
|
||
| const { setFieldValue } = useFormikContext(); |
There was a problem hiding this comment.
You don't need this you can access the functions you need to set the field value via that useStates above
There was a problem hiding this comment.
This was the same piece of code used in other forms, I will keep like that to be consistent. In case we decide to a general change later on. Thanks for your review. Updated the other suggestions.
There was a problem hiding this comment.
Also, see comment here related to the useField : #8104
jbradberry
force-pushed
the
execution-environments
branch
from
2b07625
to
3b407ef
Compare
nixocio
force-pushed
the
ui_expand_7887
branch
2 times, most recently
from
8988079
to
39f878d
Compare
AlexSCorey
approved these changes
Oct 8, 2020
dsesami
approved these changes
Oct 12, 2020
|
Unable to freeze job graph: Job awx-push-new-schema depends on awx-ui which was not run. |
|
regate |
|
Unable to freeze job graph: Job awx-push-new-schema depends on awx-ui which was not run. |
Add organization as part of creating/editing an execution environments If one is a `system admin` the Organization is an optional field. Not providing an Organization makes the execution environment globally available. If one is a `org admin` the Organization is a required field. See: ansible#7887
nixocio
force-pushed
the
ui_expand_7887
branch
from
39f878d
to
26dec3b
Compare
|
PR rebased @dsesami. |
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add organization when creating/editing an execution environments.
If one is a
system adminthe Organization is an optional field. Notproviding an Organization makes the execution environment globally
available.
If one is a
org adminthe Organization is a required field.See: #7887
System Admin:
Org Admin