Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drain to Job Management proto #30157

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

damondouglas
Copy link
Contributor

@damondouglas damondouglas commented Jan 30, 2024

This PR closes #30155 and addresses #29669 and #30250 by:

  • adding a Drain method to the Job Management proto

  • regenerate stubs for the Go SDK via: go generate in sdks/go/pkg/beam/model

To validate this change, I performed the following validations for each of the three SDKS:

Java validation

Using IntelliJ ran gradle tasks:

  • :model:job-management:generateProto
  • :runners:check NOTE: the same tests that failed here on local machine also failed in master

Python validation

Using pyenv

pip install -e ".[gcp,test]"
pytest apache_beam/runners/portability

Go validation

cd sdks
go test ./go/pkg/beam/runners/...

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a221f98) 38.42% compared to head (9ad3079) 38.42%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #30157   +/-   ##
=======================================
  Coverage   38.42%   38.42%           
=======================================
  Files         697      697           
  Lines      102215   102215           
=======================================
  Hits        39272    39272           
  Misses      61315    61315           
  Partials     1628     1628           
Flag Coverage Δ
go 54.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damondouglas damondouglas marked this pull request as ready for review January 30, 2024 20:35
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Drain is a request to:
// - stop a pipeline Job from ingesting new data from input sources
// - process remaining data in the pipeline
// - truncate Splittable DoFns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"truncate Unbounded Restrictions"

@damondouglas damondouglas merged commit 9361141 into apache:master Feb 8, 2024
89 checks passed
@damondouglas damondouglas deleted the 30155-drain-proto branch February 8, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add drain method to Job Management proto
4 participants