Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drain to Job Management proto #30157

Merged
merged 3 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add Drain to Job Management proto
  • Loading branch information
damondouglas committed Jan 31, 2024
commit 59abf0b8a545e09db5c8e4883c58db3f41fd65d4
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ service JobService {
// Cancel the job
rpc Cancel (CancelJobRequest) returns (CancelJobResponse);

// Drain the job
rpc Drain (DrainJobRequest) returns (DrainJobResponse);
Abacn marked this conversation as resolved.
Show resolved Hide resolved

// Subscribe to a stream of state changes of the job, will immediately return the current state of the job as the first response.
rpc GetStateStream (GetJobStateRequest) returns (stream JobStateEvent);

Expand Down Expand Up @@ -127,6 +130,19 @@ message CancelJobResponse {
JobState.Enum state = 1; // (required)
}

// Drain is a request to:
// - stop a pipeline Job from ingesting new data from input sources
// - process remaining data in the pipeline
// - truncate Splittable DoFns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"truncate Unbounded Restrictions"

message DrainJobRequest {
string job_id = 1; // (required)
}

// Valid responses include any terminal state or DRAINING
message DrainJobResponse {
JobState.Enum state = 1; // (required)
}

// A subset of info provided by ProvisionApi.ProvisionInfo
message JobInfo {
string job_id = 1; // (required)
Expand Down
805 changes: 469 additions & 336 deletions sdks/go/pkg/beam/model/fnexecution_v1/beam_fn_api.pb.go

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

297 changes: 171 additions & 126 deletions sdks/go/pkg/beam/model/jobmanagement_v1/beam_expansion_api.pb.go

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading