fix parsing of identifiers after % symbol
#927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If/when this is merged, I plan to make a 0.36.1 release that includes this fix |
alamb
commented
Jul 20, 2023
| Some(sch) if self.dialect.is_identifier_start('%') => { | ||
| self.tokenize_identifier_or_keyword([ch, *sch], chars) | ||
| } | ||
| _ => self.consume_and_return(chars, Token::Mod), |
There was a problem hiding this comment.
This is the bug fix. At is at this point the % has been consumed by chars.next() so calling consume_and_return` skips another character by accident
It probably doesn't matter for ' ' but it does matter for everything else in this match arm
Pull Request Test Coverage Report for Build 5616064223
💛 - Coveralls |
crepererum
approved these changes
Jul 21, 2023
|
Thanks for the reviews @izveigor and @crepererum -- I should point out that I studied the rest of the change carefully and I did not find similar bugs in the handling of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in parsing 'c%d1
where thed` was accidentally consumed.Introduced in #913 released in sqlparser-rs 036.0
Closes #926