chore(deps): update sqlparser requirement from 0.35 to 0.36 #7037
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](apache/datafusion-sqlparser-rs@v0.35.0...v0.35.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
github-actions
bot
added
sql
| @@ -415,13 +415,13 @@ select c1/c5 from decimal_simple; | |||
|
|
|||
|
|
|||
| query T | |||
| select arrow_typeof(c5%cast(0.00001 as decimal(5,5))) from decimal_simple limit 1; | |||
| select arrow_typeof(c5 % cast(0.00001 as decimal(5,5))) from decimal_simple limit 1; | |||
There was a problem hiding this comment.
I believe this was due to apache/datafusion-sqlparser-rs#913 from @izveigor where without a space this is parsed to something different.
I think this is a bug in sqlparser
c1%c5 is being parsed like this (note the value is 5, not c5)
BinaryOp {
left: Identifier(
Ident {
value: "c1",
quote_style: None,
},
),
op: Modulo,
right: Value(
Number(
"5",
false,
),
),
},
With spaces, c1 % c5 is parsed correctly:
BinaryOp {
left: Identifier(
Ident {
value: "c1",
quote_style: None,
},
),
op: Modulo,
right: Identifier(
Ident {
value: "c5",
quote_style: None,
},
),
},```
I will file a ticket in sqlparser
There was a problem hiding this comment.
There was a problem hiding this comment.
Proposed PR to fix: apache/datafusion-sqlparser-rs#927
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on sqlparser to permit the latest version.
Changelog
Sourced from sqlparser's changelog.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)