-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the POSITION
function
#8969
Comments
I think this is a good first issue, though it will require updating sqlparser-rs and then waiting for that to be released and making a change in datafusion |
I would like to try that |
Hello, @alamb I have created a PR plz review it if you have time. Additionally, I have some other problems:
|
Thank you @Lordworms - I have it on my
From my perspective there is no particular deadline for any issue. Instead, if someone is working on an issue but wasn't able to finish it before someone else needs / wants to work on the same thing, that other person can simply make a PR. I think most contributors are polite and check with the person who first signaled interest before working on something, but just because someone else might be working on something doesn't prevent anyone else from doing so
I think making a draft PR to run the full suite of tests so you know which ones may need to run locally is a very reasonable strategy
I don't have a good answer for this -- Rust development environments in general do require significant resources |
Thank you, got it! |
adding proto
* feat: issue #8969 adding position function * reuse Instr
Seems that we should close this issue as it was completed in #8988 |
Thank you @SteveLauC -- good call |
Is your feature request related to a problem or challenge?
The idea is to support the
position
function from postgres:https://www.postgresql.org/docs/9.1/functions-string.html
For example
Describe the solution you'd like
As @zy-kkk points out on #8862 (comment) postgres has special syntax
To support the syntax
position('world' in 'Helloworld') = 6
we probably need to do it in at https://github.com/sqlparser-rs/sqlparser-rs and add support for this syntax , which may be like adding theoverlay
function in apache/datafusion-sqlparser-rs#594.Then we can change the datafusion planner to recognize that special syntax and call the
instr
function in #8862Describe alternatives you've considered
No response
Additional context
This came up while implementing #8862
The text was updated successfully, but these errors were encountered: