Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: improve contributor guide to explain how to work with tickets #8999

Merged
merged 7 commits into from
Jan 29, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 25, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

Recently the question of who is / could be working on what ticket came up in discussions. For example"

I think it would be good to clarify the contributing guide in this case

What changes are included in this PR?

  1. Update the contributing guide to explain the existing decorum: work on what you want, but it is polite to announce on tickets and file new tickets for new behavior

Are these changes tested?

Docs only

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label Jan 25, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 25, 2024
@alamb alamb requested a review from andygrove January 25, 2024 19:16
docs/source/contributor-guide/index.md Outdated Show resolved Hide resolved
docs/source/contributor-guide/index.md Outdated Show resolved Hide resolved
@simicd
Copy link
Contributor

simicd commented Jan 25, 2024

Thanks for expanding the contributor guide @alamb, very clear!


You can find a curated
[good-first-issue](https://github.com/apache/arrow-datafusion/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[good-first-issue](https://github.com/apache/arrow-datafusion/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)

Moved.

@alamb alamb requested review from viirya and comphead January 29, 2024 17:51
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb would be nice to have a link to contribution.md from the top level page in

https://github.com/apache/arrow-datafusion#contributing-to-datafusion section

@alamb
Copy link
Contributor Author

alamb commented Jan 29, 2024

Thanks @alamb would be nice to have a link to contribution.md from the top level page in

https://github.com/apache/arrow-datafusion#contributing-to-datafusion section

Excellent call -- done in 94bbca7

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 29, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks @alamb

@alamb alamb merged commit 90a821a into apache:main Jan 29, 2024
4 checks passed
@alamb alamb deleted the alamb/update_contributor_guide branch January 30, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants