chore(deps): update sqlparser requirement from 0.35 to 0.36.1 #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. - [Changelog](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/CHANGELOG.md) - [Commits](apache/datafusion-sqlparser-rs@v0.35.0...v0.35.0) --- updated-dependencies: - dependency-name: sqlparser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
crepererum
approved these changes
Jul 21, 2023
|
CI fails, I think you need to update the lock file for the CLI. |
alamb
commented
Jul 21, 2023
| @@ -2175,13 +2175,13 @@ mod tests { | |||
| async fn create_variable_err() -> Result<()> { | |||
| let ctx = SessionContext::new(); | |||
|
|
|||
| let err = plan_and_collect(&ctx, "SElECT @= X#=?!~ 5") | |||
There was a problem hiding this comment.
without chis change, sqlparser complains (reasonably) about X#=?!~ 5 not being a valid identifier.
https://github.com/apache/arrow-datafusion/actions/runs/5621460600/job/15232281958?pr=7051
---- execution::context::tests::create_variable_err stdout ----
thread 'execution::context::tests::create_variable_err' panicked at 'assertion failed: `(left == right)`
left: `"SQL error: ParserError(\"Expected end of statement, found: =\")"`,
right: `"Error during planning: variable [\"@\"] has no type information"`', datafusion/core/src/execution/context.rs:2182:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
So I changed the test to preserver the error (rather than updating the error to be a parse error)
jackwener
approved these changes
Jul 24, 2023
|
Merge it quickly because of it may accumulate some conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7037
Rationale for this change
Keep up with dependencies
What changes are included in this PR?
See title
Are these changes tested?
Yes, existing CI
Are there any user-facing changes?