Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update link and title of quickstart #16638

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

edgar2020
Copy link
Contributor

Updates the download link in the quickstart to use the internal download page rather than route to external domain. Also updates title to be "Local quickstart" instead of "Quickstart (local)"
This PR has:

  • been self-reviewed.

docs/tutorials/index.md Outdated Show resolved Hide resolved
@@ -39,5 +39,6 @@
"react": "^17.0.2",
"react-dom": "^17.0.2",
"replace-in-file": "^4.3.1"
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not check in this change.

@techdocsmith
Copy link
Contributor

@edgar2020 , great start. I think we should use the same case in the sidebar as the title. Also I don't think we should check in the package.json.

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit b43f406 into apache:master Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants