-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23025][upsert-kafka] Fix upsert-kafka produce duplicates when … #16242
Conversation
…enable object reuse
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit fdfe95d (Tue Jun 22 12:09:46 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixing. I only left 2 minor comments. Others looks good to me.
...t/java/org/apache/flink/streaming/connectors/kafka/table/BufferedUpsertSinkFunctionTest.java
Outdated
Show resolved
Hide resolved
...t/java/org/apache/flink/streaming/connectors/kafka/table/BufferedUpsertSinkFunctionTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fsk119 could you also open a check-pick PR for master branch ? |
cc #16257 |
…enable object reuse
What is the purpose of the change
Fix upsert-kafka produce duplicates when enable object reuse.
Verifying this change
BufferedUpsertSinkFunctionTest
to verify the results if enable object reuse.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation