Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code depending on JVM default charset #10529

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fix code depending on JVM default charset #10529

merged 1 commit into from
Jun 19, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Jun 18, 2024

Found by #10518

@github-actions github-actions bot added the flink label Jun 18, 2024
liurenjie1024
liurenjie1024 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi for fixing this.

@liurenjie1024 liurenjie1024 merged commit 8248663 into apache:main Jun 19, 2024
13 checks passed
@findepi findepi deleted the findepi/fix-code-depending-on-jvm-default-charset-b8131a branch June 19, 2024 07:09
@findepi
Copy link
Member Author

findepi commented Jun 19, 2024

thanks @liurenjie1024 for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@stevenzwu stevenzwu Awaiting requested review from stevenzwu

@danielcweeks danielcweeks Awaiting requested review from danielcweeks

Assignees
No one assigned
Labels
flink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@findepi @liurenjie1024