Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Java 8 #10518

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop support for Java 8 #10518

wants to merge 2 commits into from
+54 −63

Conversation

findepi
Copy link
Collaborator

@findepi findepi commented Jun 17, 2024 •
edited
Loading

Relates to: #10474

@findepi findepi marked this pull request as draft June 17, 2024 14:08
@findepi findepi mentioned this pull request Jun 17, 2024
Merged
@findepi findepi mentioned this pull request Jun 17, 2024
Merged
@findepi findepi mentioned this pull request Jun 18, 2024
Merged
@findepi findepi force-pushed the findepi/8 branch 2 times, most recently from 4096cb9 to 5fd990a Compare June 18, 2024 08:31
@findepi findepi mentioned this pull request Jun 18, 2024
Merged
nastra
nastra reviewed Jun 18, 2024
View reviewed changes
baseline.gradle Outdated Show resolved Hide resolved
@findepi findepi mentioned this pull request Jun 19, 2024
Merged
@nastra
Copy link
Contributor

nastra commented Jun 20, 2024 •
edited
Loading

just FYI that you'd also need to update

iceberg/deploy.gradle

Line 21 in 2519ab4

throw new GradleException("Releases must be built with Java 8")

iceberg/site/docs/contribute.md

Line 87 in 7151401

Iceberg is built using Gradle with Java 8 or Java 11.

iceberg/README.md

Line 54 in b7a0bea

Iceberg is built using Gradle with Java 8, 11, or 17.

@github-actions github-actions bot added the docs label Jun 20, 2024
@findepi
Copy link
Collaborator Author

findepi commented Jun 20, 2024

just FYI that you'd also need to update

good point, updated.
also found couple different places where we inspect JavaVersion.current()

@nastra nastra added this to the Iceberg 2.0.0 milestone Jun 20, 2024
@findepi
Drop support for Java 8
d93402b
@findepi
Update baseline gradle plugin to 5.58.0
27248b4 
Among other things, this pulls newest version of error-prone which adds
new useful checks.
@findepi findepi marked this pull request as ready for review July 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
arrow build core data docs flink hive INFRA parquet
Projects
None yet
Milestone
Iceberg 2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@findepi @nastra