Let ./gradlew clean clean everything
#10601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snazy
force-pushed
the
clean-all
branch
2 times, most recently
from
ca700a5
to
a566be8
Compare
snazy
force-pushed
the
clean-all
branch
2 times, most recently
from
f41486e
to
f2643c6
Compare
... including: * not-enabled Spark versions * not-enabled Flink versions * site/ directories * venv/ in site/ and open-api/
nastra
reviewed
Jul 1, 2024
| apply from: file("$projectDir/v3.5/build.gradle") | ||
| tasks.named("clean", Delete) { | ||
| for (ver in knownSparkVersions) { | ||
| delete("$projectDir/v${ver}/spark/build") |
There was a problem hiding this comment.
this (and other build) folder(s) seem to be properly cleaned up when running ./gradlew clean so why would we want to add them here?
There was a problem hiding this comment.
"versions" that are not enabled in the current build are not properly cleaned up, right?
There was a problem hiding this comment.
one could argue that clean should only be running against the Spark version(s) that are currently being passed to Gradle rather than calling clean against all known Spark modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... including:
spark-warehousedirectories in Spark versions