Add interfaces for Action CheckSnapshotIntegrity #10642
Open
+91
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yufei Gu <yufei@apache.org>
himadripal
reviewed
Jul 9, 2024
|
|
||
| /** | ||
| * Passes an alternative executor service that will be used for snapshot integrity checking. If | ||
| * this method is not called, snapshot integrity checker will still be running by a single |
There was a problem hiding this comment.
nit: 2nd part can be rewritten as a single threaded executor service is used by default
himadripal
reviewed
Jul 9, 2024
| * "/path/to/00001-8893aa9e-f92e-4443-80e7-cfa42238a654.metadata.json". | ||
| * @return this for method chaining | ||
| */ | ||
| CheckSnapshotIntegrity targetVersion(String targetVersion); |
There was a problem hiding this comment.
should the param name be changed to targetVersionFilePointer or targetVersionMetadataFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Yufei Gu yufei@apache.org
Co-authored-by: Huaxin Gao huaxin_gao@apple.com
This PR adds interfaces for Action CheckSnapshotIntegrity. We will have another PR to implement the interfaces in Spark 3.4 and Spark 3.5.